heimdall icon indicating copy to clipboard operation
heimdall copied to clipboard

[ENHANCEMENT] Add "retryDoer/hystrixDoer" implementation

Open MichaHoffmann opened this issue 6 years ago • 1 comments

When comparing https://github.com/gojek/heimdall/blob/master/httpclient/client.go and https://github.com/gojek/heimdall/blob/master/hystrix/hystrix_client.go it seems that they only differ fundamentally in their respective Do methods. One could factor that part out into seperate Doer implementations and only have one httpclient implementation that delegates to a configurable Doer.

I would be willing to file a PR if that is acceptable.

MichaHoffmann avatar Sep 04 '19 07:09 MichaHoffmann

Sure @MichaHoffmann you can work on this

rShetty avatar Sep 06 '19 05:09 rShetty