Meivyn

Results 61 comments of Meivyn

There is still an issue when you switch two items when they are forced to be stacked and contains more than one stack, but not even sure if this is...

Closing as this seems to have been fixed in the current release.

I would suggest using this instead since this would be future-proof, and also adds support for `IconOverlay2`: ```lua function buttonProto:UpdateOverlay() local _, _, _, quality = GetContainerItemInfo(self.bag, self.slot) SetItemButtonOverlay(self, self.itemId...

@Cidan Would you mind me doing another PR for this? The author seems to be unavailable. This is understandable considering the long wait time we had with PRs due to...

> Looking at [ItemButtonTemplate.lua](https://github.com/tomrus88/BlizzardInterfaceCode/blob/0b94f21f74dbb5690930ab5015b4204a53153d8d/Interface/FrameXML/ItemButtonTemplate.lua) it looks like Conduit items get a special frame - when I get home, I can see if they do. I am not sure what `IconOverlay2`...

Technically you add support for both overlays (`IconOverlay` and `IconOverlay2`), the frames are already created on the button by the base game. I am unsure what the `childrenNames` are used...

> GetContainerItemInfo is already cached locally in the WoW client - this call is not networked unless there's a miss. Isn't it still faster/less overhead to cache the values and...

> We'd be adding complexity around cache invalidation, and adding more memory pressure to the client should we build a cache for this. I'd argue that we do not really...

No clue if that thread is still being watched, but I noticed this while playing Joetastic maps: ![image](https://user-images.githubusercontent.com/793322/190836920-d1f47026-4818-430e-9e07-2ea22f19d878.png) You can see that I didn't miss and that the arc isn't...

Well this looks like a bug to me. But rather a base game bug than a ChroMapper one. Thanks for pointing it out.