Mayuresh Choudhary
Mayuresh Choudhary
@rohanr18 yes I have done doctests for exceptions.
> Instead of returning a string error you should raise one Hey, @CaedenPH thanks for reviewing my PR. I have made all the necessary changes and also done doctests for...
hey, @CaedenPH once again thanks for reviewing my PR. I have made the changes you pointed out and have commented on a few changes to why I have made use...
> @Mayuresh-22 You have not resolved all the comments that I made I think I have resolved now
Hey, @Aniyo44 Thank You for opening an issue it seems that they have moved their website to a new domain. I am working on it and will make the PR....
Hey, describe your PR and which issue it solves.
Hey I think you have misunderstood the logic part of the Minglr, temp mail detection should be done at the time of registration and hence the logic for the validation...
I am checking few conflicts I'll get back to you in few hours
Hey @tarnibalgoher5, I saw and tested the changes and there are layout issues. I suggest you test the changes thoroughly before making PR. ![image](https://github.com/Mayuresh-22/Minglr/assets/111348926/94e8053b-e364-44f3-aeb6-260672a81092) ![image](https://github.com/Mayuresh-22/Minglr/assets/111348926/0689d2f6-8f59-472e-beb0-d14eaa522c8e)
Hey @harmeetsingh11, thank you for creating this issue. Minglr is solely managed by me and there are no other members who can work as reviewers (yet).