Python
Python copied to clipboard
Adding remove_vowels.py and camel_case_to_snake_case.py
Describe your change:
- [x] Add an algorithm?
- [ ] Fix a bug or typo in an existing algorithm?
- [ ] Documentation change?
Checklist:
- [x] I have read CONTRIBUTING.md.
- [x] This pull request is all my own work -- I have not plagiarized.
- [x] I know that pull requests will not be merged if they fail the automated tests.
- [x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
- [x] All new Python files are placed inside an existing directory.
- [x] All filenames are in all lowercase characters with no spaces or dashes.
- [x] All functions and variable names follow Python naming conventions.
- [x] All function parameters and return values are annotated with Python type hints.
- [x] All functions have doctests that pass the automated testing.
- [ ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
- [ ] If this pull request resolves one or more open issues then the commit message contains
Fixes: #{$ISSUE_NO}
.
@rohanr18 yes I have done doctests for exceptions.
Instead of returning a string error you should raise one
Hey, @CaedenPH thanks for reviewing my PR. I have made all the necessary changes and also done doctests for exceptions.
hey, @CaedenPH once again thanks for reviewing my PR. I have made the changes you pointed out and have commented on a few changes to why I have made use of those variables. If there is anything more, guide me and I will make those changes.
@Mayuresh-22 You have not resolved all the comments that I made
@Mayuresh-22 You have not resolved all the comments that I made
I think I have resolved now