Max Verevkin

Results 300 comments of Max Verevkin

## HLS does not work First of all, I'm not sure what the range of hue in HLS color space should be. I created [a test project](https://github.com/MaxVerevkin/tiny-sixel) to play with...

I fixed the check for the range of hue and now I get ![image](https://user-images.githubusercontent.com/34583604/117568495-37710180-b0c9-11eb-90b3-d46ab808cbb6.png) `fn hls_to_rgb(h: u16, l: u16, s: u16) -> (u16, u16, u16) {` is obviously wrong.

This patch produces the same output as `foot` (it contains some `cargo fmt`-generated changes) ```diff diff --git a/alacritty_terminal/src/graphics/sixel.rs b/alacritty_terminal/src/graphics/sixel.rs index 221fe7c..37d8acd 100644 --- a/alacritty_terminal/src/graphics/sixel.rs +++ b/alacritty_terminal/src/graphics/sixel.rs @@ -58,11 +58,11 @@...

> wezterm I assume it uses the type of HLS where "hue=0" corresponds to red, whereas in foot and mlterm it corresponds to blue (which is correct according to https://archive.org/details/bitsavers_decstandar0VideoSystemsReferenceManualDec91_74264381/page/n927/mode/2up).

> Does the patch in [#4763 (comment)](https://github.com/alacritty/alacritty/pull/4763#issuecomment-835810836) match the implementation in libsixel? I haven't read `libsixel` code. I just tuned your code to match `foot`'s behavior.

`C-t` will work even without this line.

But this line makes some floating terminals basically unusable in case the keybinding starts with a space.

I have ```lua lvim.leader = "space" --- table.insert(lvim.builtin.terminal.execs, { "python", "tp", "Python" }) ``` and `C-t` will toggle this terminal once I open it with `tp`. I get it that...

> simply do this It's a bit more complicated ```lua lvim.builtin.terminal.on_config_done = function () vim.api.nvim_del_keymap("t", "tp") end ``` > compared to what is actually required to set it if this...