Max Verevkin

Results 300 comments of Max Verevkin

Also I would prefer to somehow keep the old configuration working for now and not break the existing configs.

This is in scope for this project. I will probably not implement it myself in the near future, but I'm open to the discussion on how it should work and...

Funny thing is that the comments in `parse.rs` suggest this was the intention all along https://github.com/greshake/i3status-rust/blob/a2704aedebf8818628977cde99a5a1886e63e09f/src/formatting/parse.rs#L114-L116

It could be implemented somehow, but I'm not convinced it is worth it.

We don't need `async_trait` here :) ```diff diff --git a/src/locator.rs b/src/locator.rs index 9aa6b9773..f5ebd654a 100644 --- a/src/locator.rs +++ b/src/locator.rs @@ -1,10 +1,10 @@ use crate::errors::{Error, ErrorContext, Result, StdError}; use std::borrow::Cow; use...

Interesting that - Formatting changed so much across editions (just didn't expect that) - `trait Future` was added to the prelude, but neither rustc nor clippy catched that we can...

I would like to make it fully configurable, e.g. ```toml [signals] toggle_hidden = "SIGUSR1" hide = 0 show = 1 ``` > (I'd like to try my hand at this...

> Sorry, I don't quite understand how this config snippet would work? What do 0 and 1 correspond with? Zero means `SIGRTMIN+0`. In this example sending zero hides the bar,...

Thanks, the change looks good to me. Before merging please run `cargo fmt` (it turns out the CI check for formatting was not working all this time :laughing:).