Max Kellermann

Results 462 comments of Max Kellermann
trafficstars

This is probably a good idea, but the code doesn't look so good. - `tryParseStringFilter()` (badly named, shouldn't start with lower case) allocates memory for no reason - `ParseStringFilter()` is...

The array is still not `constexpr`, thus it's not guaranteed to initialize at compile time; and the function still allocates heap memory.

Your log shows that you never had any playback.

Hmmm, if this is specific to macOS, then unfortunately I cannot help. macOS support has been removed from MPD because there were a bunch of known bugs but no volunteer...

This bug report is incomplete because you chose not to post a log. Also to reproduce your problem, a demo file is needed.

Bad commit message: the "Fixes" tag is only present in the PR text but not in the commit message; and the commit message doesn't explain what is being fixed and...

I think the commit message is now wrong. It implies that the prefix was ignored, but really the suffix was ignored instead.

> Correct duration for streams with mpg123 plugin. What is the correct duration?

This project does not support the ncmpcpp visualizer. This ncmpcpp feature is considered an abuse of an experimental MPD feature, and this ncmpcpp "feature" may be a reason to remove...

I'm not convinced that this is a good idea or even useful.