Max Kellermann

Results 496 comments of Max Kellermann

Your first commit consists almost completely of code you copied. Adding redundant code is not acceptable.

> @MaxKellermann can we consider merging this? No, because the overall concept of this implementation is confusing and too complicated. Look at the example configuration: ``` event=GotoLookup (goto) event=AddWaypoint goto...

The framework currently allows one "widget" to be placed below the map, which can be the cross section, for example. Airspace warnings use the same API, so they replace the...

Please upload task files and IGC files describing various outcomes (less than 95%, between 95% and 99%, 100%) - and say what the correct calculation results would be. That way,...

There are never objections to people who want to improve XCSoar. Your work should contain a unit test so we can reproduce the results and can ensure it continues to...

> I don't know what version it started on. Find out, and then bisect the faulty git commit.

Oh, that data structure was designed when nobody could imagine that loggers could store so many files - pilots were happy they didn't have to manually delete flights - older...

Off-topic, but if you feel some piece of code is in need of more code comments, write a bug report - unfortunately, nobody reviews my contributions and grouches at me...

Sorry, I have no macOS therefore cannot help with this problem