Max Kellermann

Strangely, the "Reopen and comment" button is grayed out even for me. No idea why.

Apparently, GH doesn't allow reopening a PR if there was a force-push while it was closed. How stupid! To be able to reopen it, you need to force-push the old...

Doesn't work. I guess GH requires you to push the exact commit id that was current when the PR was closed.

> I wanted to split the feature into two commits. On this one. Your second commit does two distinct unrelated things: - refactor two existing fields into the array `basic_traffic_brushes`...

Since you did not specify a version that worked, I figure that you never tried this with any other XCSoar version?

This PRs copies lots of existing code. That is not acceptable and will not get merged.

Did you consult with the vendor about this? Passing around illegal date values can result in all sorts of follow-up bugs (like assertion failures), so I'd rather not do this,...

Unfortunately, LXNAV's explanation doesn't make them sound competent. How can you start recording a flight if you don't have a GPS fix yet? (a GPS fix always comes with a...

Timeout shouldn't happen. But fixing a timeout by accepting bogus values sounds suspicious. What is the real reason for the timeout?

> * Engine/Waypoints.cpp I'm not sure whether drawing that in there is not violating layering The Engine (and any low-level code) should not have anything UI or language related.