Max Kellermann

I need a test file.

That's a problem with all music files, and MPD supports ReplayGain in many file formats. But I havn't heard of the possibility of ReplayGain tags in the file formats you...

How is this supposed to work on Windows?

This crash occurs inside libsoxr; it is hard to tell if this is a MPD bug or a libsoxr bug. Please paste a disassembly of the crashing function, at least...

libsoxr source code is very obscure and riddled with macros... *shudder*.... This: ``` 0x00007f71ab06ba30 : vmovss (%rsi,%rax,4),%xmm0 0x00007f71ab06ba35 : mov (%rdi,%rax,8),%rdx => 0x00007f71ab06ba39 : vmovss %xmm0,(%rdx,%r8,1) ``` is from `data-io.c`:...

This very obscure badly documented doing-everything-in-one commit broke it: https://sourceforge.net/p/soxr/code/ci/52888cd410ae356bf3aa26d8fa106754b8fd8990 Given that the code is extremely ugly, and there is no API documentation and no usable changelog, and now this...

You can switch at runtime between all resamplers that have been enabled at compile time: https://www.musicpd.org/doc/html/plugins.html#resampler-plugins

Is that necessary? Where is that documented?

"not as explicit as it might be" is an understatement. The "documentation" is not only not explicit, it is also not even implicit. Nothing in these brief comments tells me...

Nobody ever cared, because these days, people use systemd-journald instead of the built-in logger. But if you believe this legacy code should be improved, go ahead. Though I'd prefer ISO8601....