MPD
MPD copied to clipboard
Log file timestamp improvements
Feature request
Hi there!
Big fan of mpd and I use it heavily, daily!
Thanks very much for this project and I appreciate all you do.
Recently, I've noted that the timestamps in the mpd log could be improved.
https://github.com/MusicPlayerDaemon/MPD/blob/master/src/LogBackend.cxx#L98
At present, they do not appear to adhere to any standard.
Could it be possible to modify the timestamps used here to adhere to, perhaps RFC1123Z time standard (i.e. log: Mon, 02 Jan 2006 15:04:05 -0700 rather than Jan 02 15:04)
If there is a technical reason why the timestamps do not include anything besides Month, Day, Hour, Minute, could you please explain that, and/or add a note/comment to the relevant section of code for posterity?
If there's no technical reason preventing this, I'd be happy to submit a PR to address this issue.
Nobody ever cared, because these days, people use systemd-journald instead of the built-in logger. But if you believe this legacy code should be improved, go ahead. Though I'd prefer ISO8601. There's code for that in the repository: https://github.com/MusicPlayerDaemon/MPD/blob/master/src/time/ISO8601.hxx