Matthew Mckee
Matthew Mckee
there is some enterprise level business logic that I would like to implement in gdstk without it being pushed to the public package, so I'm trying to make some changes...
I'm looking at `evaluate_expr_compare` now, and in the `ast::Expr::Name` arm the `CmpOp` types left are `Lt`, `LtE`, `Gt`, `GtE`. Are these arms that we intend to cover? It seems like...
Cool, sounds good, I'm up for that
@heitzmann do you know what has causes this error? I am developing on Ubuntu 24.04 so was unaware of such an issue with macos and windows
in RaithData::copy_from the code is as follows ```cpp ... if (base_cell_name) free_allocation(base_cell_name); base_cell_name = NULL; if (raith_data.base_cell_name) base_cell_name = copy_string(raith_data.base_cell_name, NULL); ``` I think it should just be ```cpp ......
Sorry for not getting back to you sooner, i believe this is fixed so will close this issues
Thank you, this is my first time working with c++ tbh so I'm glad to hear it's not horrible. I will get these changes updated asap.
@heitzmann is there any chance of this getting merged soon? I'm currently under some pressure at work to get this done so if you have a timeline that would be...
Yeah, I'm all done with my changes now. Thanks.
I was having some issues so I didn't manage to test much, my apologies. I will get these issues fixed asap