heitzmann
Add Raith MBMS Paths
from #252. I have implemented mbms path functionality into the FlexPath Object (raith_data and base_cell_name), and added support for reading and writing to and from gds. I have also added more appropriate type hints to the gdstk.pyi file. These changes should not affect any pre-existing functionality.
Thanks @MatthewMckee4 ! That's quite the effort. I'll try to go over your changes this weekend!
Thank you, this is my first time working with c++ tbh so I'm glad to hear it's not horrible. I will get these changes updated asap.
@heitzmann is there any chance of this getting merged soon? I'm currently under some pressure at work to get this done so if you have a timeline that would be greatly appreciated.
I saw a few pushes so I was not sure you were finished with the changes. If you are, we can merge it already!
Tests are failing with a segfault. Have you tested locally, @MatthewMckee4 ?
I was having some issues so I didn't manage to test much, my apologies. I will get these issues fixed asap
@heitzmann I am unable to reproduce the issues on my device but from the logs, I can see some issues:
I have fixed the issue on line 160, this was simply me writing the wrong method. The other issue though comes from:
where dwelltime_selection is:
would I be right in changing this to:
or
If not whats the correct casting function?
@MatthewMckee4 I went over all the changes and made a few modifications I thought necessary. Could you please test commit https://github.com/heitzmann/gdstk/commit/2c963bae25eda75b4aa1580d96cbde93cacefe8c to make sure it works? I don't have a way to test the Raith data locally. If all's working, we can create a new release with the new feature. And thanks again for the push!