Matej Tomes

Getting id of intersected mesh face

4

Recently I needed to get the id of the face which was hit by a ray. Is there now any way of getting it? For now I've solved it by...

OpenADAS: Expand ADF15 headers

7

Recently I had to add an ADF15 file sent to me from ADAS which has a header the current parser doesn't recognise. I changed the adf15 parsing slightly to make...

Add tests for radiation models

2

Radiation models should get tests making sure they provide the expected spectra and are not changed accidentally: - [x] GaussianLine - [x] MultipletLineShape - [x] StarkBroadenedLine - [x] BeamCXLine -...

Draft: New beam architecture

6

This is the work in progress of the new beam architecture (mentioned in #292). There still can be major changes, please use the branch with caution. I wanted to publish...

OpenADAS DEFAULT_REPOSITORY_PATH from environment variable

9

Hi, I think it would be great if we could pull the default repository path for OpenADAS repository from environment variable (e.g. CHERAB_OPENADAS_DEFAULT_REPOSITORY_PATH). The [change](https://github.com/cherab/core/blob/547e7d3b5ae979ae4bf7403c6ba1893c66b80bd3/cherab/openadas/repository/utility.py#L25C1-L25C24) I propose would be quite...

Fallback value for atomic data requests outside of data range?

17

Currently there are two ways how requests of atomic data outside of data range are handled. 1. An error is returned when the interpolator is requested to extrapolate 2. Interpolator...

Add access to plasma model properties

1

Currently PlasmaModel attributes are not accessible from python. Making some of them accessible would provide an easier way of investigating and understanding results provided by cherab. I think in general...

Move geometrical aspects of the Beam from the Beam to the BeamAttenuator class

1

I think it would be better if the geometrical description of the beam was moved from the `Beam` class to the `BeamAttenuator` class. It is the `BeamAttenuator` which provides the...

Class for managing lists holding same types

6

ModelManagers are now being used in several places as [beam node](https://github.com/cherab/core/blob/d191b859180c20ecb86ca60d5f070f299004fba5/cherab/core/beam/node.pyx#L39) and [plasma node](https://github.com/cherab/core/blob/d191b859180c20ecb86ca60d5f070f299004fba5/cherab/core/plasma/node.pyx#L166). Now the same could be use in the Zeeman lineshape models (PR #246 ) and also...

Add functionality listing available rates in the OpenADAS repository

1

I was asked about this functionality a few times and I think it is not a bad idea to add functions which would list available rates without the data. The...