Matej Tomes

Results 63 comments of Matej Tomes

I'm moving my idea from the [closed cherab issue](https://github.com/cherab/core/issues/160) . @jacklovell let me please know when you are done with your additions and I will try to add classes I...

@CnlPepper what I had in mind is not adding this to Function1D class, but using the function framework to add frequently used functions as for example Normal distribution. This is...

I think these would also come handy: - xD truncated normal (normal distribution with lower and upper limits and proper normalization) - xD uniform function with upper and lower bounds...

Hey, it seems a lot has been implemented and that changes @jacklovell had in mind seem to be in place I am coming back to the idea of adding other...

There are number of classes from the base.py which are omitted in the raysect/core/math/function/function1d/__init__.py file (e.g. MultiplyScalar1D) and have to have long imports. Is there any reason for this or...

Right I see it now, thanks @jacklovell .

Before there is a decision made, I have a question. What is the reason the parameters were not included in the init definition? Is it an honest mistake or is...

> It is likely that the same problem may occur with the files for hydrogen and hydrogen-like ions, so I think that pec_index_header should be updated in _scrape_metadata_hydrogen() and _scrape_metadata_hydrogen_like()...

Hi @roni-maenpaa thanks for the information. I'm happy that it helps, but I think adding more and more regex definitions and cases is not the proper way forward. We will...