tldr-python-client icon indicating copy to clipboard operation
tldr-python-client copied to clipboard

Published 20 hours ago • verified publisher icon tldr-pages

Feature/issue 188/enable multiple sources

Open scottmuc opened this issue 2 years ago • 4 comments

Hi @MasterOdin , @mrdavidlaing and I would like to submit this PR which relates to Issue #188 and potentially #147 and #146.

Hope you appreciate the additional tests!

If you like what you see, and would like more, we'll follow up with another PR. We have some ideas around some high-level functional testing of main but didn't want to add too much noise to this PR. We also believe we can use itertools.product to simplify the nesting of the loops.

We'll comment inline in this PR to some of the code snippets that might appear confusing at first glance.

scottmuc avatar Mar 06 '22 13:03 scottmuc

Here's a demo if it in action: https://www.loom.com/share/08ed2a0053cd4c019412e33aa47e2bd8

scottmuc avatar Mar 06 '22 14:03 scottmuc

@owenvoke would you be able to take a look at this?

Cheers

scottmuc avatar Apr 11 '22 14:04 scottmuc

Sorry for the delay on looking at this, will try to get to this sometime this week.

MasterOdin avatar Apr 11 '22 15:04 MasterOdin

@MasterOdin nudge nudge 😄

scottmuc avatar May 17 '22 19:05 scottmuc

Closing since I'm in favour of using https://github.com/charmbracelet/mods for unix program explanations. I'll work withing the constraints of local scripts/wikis/issue templates for sharing company specific stuff (which is what this PR was meant to enable).

scottmuc avatar Feb 01 '24 16:02 scottmuc