Konstantin Ivanov

Results 14 comments of Konstantin Ivanov

Fair, I didn't mention that this issue will require copy-paste. And the fact that we have to copy stuff like `INLINE` pragmas is pretty annoying (fortunately not the rewrite rules,...

I also agree that removing the instance would be better.

> Additionally, I'd like to include `groupByKeyOn`—it's less general, but it avoids those explicit preconditions by leaning on Eq. I also like how `*On` version would go without preconditions on...

Okay, added `On` versions for grouping, and sorting is out of scope of this issue. @treeowl Requesting the final review :eyes:

I failed to test the new `universum-prelude` (I tried in `xrefcheck`) because `base-noprelude` was not updated for a while and there is no version that would match the LTS we...

Would be nice to overload all functions from https://hackage.haskell.org/package/universum-0.7.1/docs/Lifted-File.html because at present some of them accept strict `Text` and others accept lazy `Text`, and it seems confusing

Oh, having CI checking my work would be really nice! I see `beam-0.8.0.0-fix-ci` branch and multiple `travis/beam-0.8.0.0-*` braches, which one should I choose?

That's weird, I see no plain `beam-0.8.0.0` branch :thinking:

Ah, thanks. I wasn't sure it was that branch you were talking about because `beam-core` tests fail to compile there (`713522b` commit). Could you check?

Oh right, I searched in my forked repository. Thanks for helping with figuring this out, I'm rebasing.