Martchus

Results 566 comments of Martchus

Since packages need to be rebuilt and an out-of-schedule deployment needed to be triggered manually, there might be some time between merging a PR here and its actual deployment. Normally...

We could merge it without the OBS check. However, it would be cleaner if you'd rebase against master. (The problem with the test should hopefully already fixed by another PR...

Yes, we can remove labels and merge it.

> And to actually turn that into a 404 such exceptions must be catched right before Mojolicious renders the result. Maybe that's possible via some hook. I suppose @kraih would...

> It's not just that using exceptions for flow control is already considered an anti-pattern. I'm not sure whether I'm following. Exceptions - regardless the cases in which they are...

The place in the C++ example where I'm catching the exception is in our case somewhere within Mojolicious, likely the function which calls the controller function. Judging by your answer...

> that there is a 5xx error fed back to users. You mean a 4xx error. > So what do you recommend we can do? There are multiple difficulties: 1....

Unfortunately the patch coverage doesn't look great. So at least also test it manually.

> .opus is working perfectly on VLC > In 2020, what is technically preventing Music Player to implement it in a relatively easy way? This player seems to rely more...

Wouldn't it make sense to rely on parser-friendly `.SRCINFO` files? I don't think users will complain that they have to provide an additional file because that's how the AUR already...