Martchus

Results 566 comments of Martchus

I've been adding the acceptance tests needed label because I want to prevent merging this automatically unless one of the team actually tested this. (Our automatic tests aren't very helpful...

The new screenshots look definitely better. I don't have much to criticize anymore but like to test it myself locally (going though all pages, including critical ones such as the...

I'd still like to fix the problems mentioned in my last comment. That should be the most important ones. > I don't expect darkmode to be perfect from the start....

> So far we don't use cookies and I would prefer if it stays this way. We're already using a cookie for the session, don't we?

As mentioned in the other issue, the Fedora docs seem indeed quite outdated. I suppose that's because the original contributors lost interest. Maybe it makes sense to remove it completely...

Also note that the ticket says "we should have a warning". The "die" is a little bit more than a warning.

The [docs](https://github.com/os-autoinst/openQA/blob/master/docs/WritingTests.asciidoc#triggering-tests-based-on-an-any-remote-git-refspec-or-open-github-pull-request) just say that one is supposed to set `NEEDLES_DIR` but not to what in which use case. That should certainly be improved. What is your use case? Custom...

> If I said that I'd got that working, I think I was confused, since my recollection now is that at one point I thought I had it working, but...

Note that last time I was working in that area introducing another variable was deemed to complicated so I resorted to dumping down the cases we can handle. So before...

I think I ditched my commits when you've saw them. Not sure whether there's a record (because I mainly remember discussing it in a jitisi session).