Martchus comments

Results 566 comments of


                                            Martchus

Only highlight the effective bugref(s) in the comments

Ok, I suppose that's good. However, it looks like tests needed to be adjusted.

Only highlight the effective bugref(s) in the comments

Ah, then I'll try it out locally.

Only highlight the effective bugref(s) in the comments

I've been pushing an additional commit that should fix it. It also works when comments are removed or newly created. However, when editing a commit it doesn't work until one...

Only highlight the effective bugref(s) in the comments

It looks like the carry over algorithm goes by the comment creation (as it looks for comments with the highest ID first) and the sorting of comments on the page...

Make lowercase settings fatal

This could be a breaking change for users, right?

Update all files to use perl "signatures"

Not sure. If we don't already use `Mojo::Base` in a module it would make sense to use 2. instead. However, the module is likely loaded at some point anyways (because...

Update all files to use perl "signatures"

I know but hopefully the compile check shows a problem when prototypes were used. At least in the cases I've encountered it ended up being a compile error. Note that...

Update all files to use perl "signatures"

Is it ready for review? Looks generally good (after a brief look).

Use the workers count from Minion 10.25 to make monitoring more reliable

Looks strange. I expected that the order might differ but there's a `,` missing.

Use the workers count from Minion 10.25 to make monitoring more reliable

Likely. Annoyingly now there's another test failure: ``` [10:07:10] t/deploy.t ................................................ 8/? Use of uninitialized value $is_admin in numeric eq (==) at template admin/workers/index.html.ep line 74. Use of uninitialized value...