Mark Waite

Results 434 comments of Mark Waite
trafficstars

Thanks for checking @kesrishubham2510. The dependencies are [downloaded with Apache Maven](https://github.com/jenkins-infra/backend-extension-indexer/blob/c18e78e4fd361f33e1ffb7fda6af4267c482564f/src/main/java/org/jenkinsci/extension_indexer/SourceAndLibs.java#L177) using the Maven repository cache. That has the added benefit that the artifact caching proxy that is used on...

@cpt1gl0 I'm not a maintainer of this plugin

I'm "+1" for the change but I think it will need to be checked that it does not break tests in the plugin bill of materials or in the acceptance...

The Jenkins [Pipeline syntax snippet generator](https://www.jenkins.io/doc/book/pipeline/getting-started/#snippet-generator) needs some additions to the pull request. The file src/main/resources/org/jenkinsci/plugin/gitea/credentials/PersonalAccessTokenBinding/config.jelly is needed in order to allow the generator to display the form. I've made...

I added two more changes for your consideration: * c214a56 Add giteaPersonalAccessToken documentation and example * 33b0b22 Simplify test script

@sahilm02 I added two more items for your consideration: * f9e1723 Improve comment in test * 47258b9 Use echo instead of println

> From a ten-second glance this looks like the wrong approach: you should rather implement `StringCredentials` and use the generic binding. I'm not sure if I understood your comment correctly....

Thanks for the feedback @jglick . I've updated with two more commits, removing the binding class and updating the automated test. The changes are: * 6ae6216a285ee08f5ed1dd7420b2ae8e8e16af4e - Document that 'Secret...

> It is not really clear to my why PersonalAccessTokenImpl exists, either. Since that class has existed since 2017, I left it alone. I didn't want to do the compatibility...

Another test case that I ran successfully, using a declarative Pipeline with the environment directive: ``` pipeline { environment { ABC = credentials('gitea-token') } agent { label '!cloud' } stages...