Mark Waite

Results 431 comments of Mark Waite
trafficstars

> Hmm oki so i guess ill wait for some additional feedback , because i am not able to merge this PR I still need to review the PR. I...

> Hello, this is just a friendly reminder as I am not sure if it wasn't forgotten :) Thanks for the reminder. I've returned from a week of vacation, will...

Thanks for the ping. I'll be busy all this weekend preparing for DevOps World and then busy all week at DevOps World. I may be able to start the review...

Extensions are unfamiliar to me. I've requested review from @rsandell and @fcojfernandez since they likely have more experience with using the extensions API than I do.

Thanks for looking at this pull request @rsandell . I'd love to merge and release it but there are reports in [JENKINS-67981](https://issues.jenkins.io/browse/JENKINS-67981) that the change does not resolve the issue....

@arymkus https://ci.jenkins.io/job/Plugins/job/git-plugin/job/PR-1233/lastStableBuild/ is the most recent stable build. It includes the hpi file.

> @MarkEWaite I tried the .hpi file from [build #25](https://ci.jenkins.io/job/Plugins/job/git-plugin/job/PR-1233/25/). Thanks! I've pushed a catch of the broader exception mentioned in the stack trace. It should be visible as a...

Closing in favor of #1322 . This pull request did not solve the issue.

I think it is an improvement and a good correction, even if it does not ultimately resolve the issue you're fixing.

@halkeye any reason that I should not merge this improvement?