Mark Waite

Results 211 comments of Mark Waite

@nijicompany and @shmarsy you'll need Apache Maven and Java 11. You'll probably want an integrated development environment (IDE) like Visual Studio Code, IntelliJ, Apache Netbeans, or Eclipse. See https://www.jenkins.io/participate/code/ for...

> Is there any update on this getting merged? It will likely be several months before I'm able to review, test, and merge this pull request.

> Will this get merged in? I could really use it, the plugin is not select the correct git ref and this looks like it fixes it! Not immediately. It...

The failure of `GitSCMTest.testBasicRemotePoll` is unrelated to the credentials binding changes and seems to be unrelated to any change in this pull request except the upgrade of `jenkins.version` from 2.263.1...

> Not to nag the obvious, but It's Summer 2022, are any "Summer of Code 2022" students going to be assigned to complete this? We could really use this functionality...

https://issues.jenkins.io/browse/JENKINS-65881 indicates that GitChangeSet cannot be serialized by the Jenkins serialization system because it includes a field that is known to be unsafe for serialization.

> Hmm i wonder what the "/* Unreliable on Windows and not a platform specific test */" means in the failing test... :) It means that the test has been...

> I advise simply pushing commits to the branch, and leaving it to up the maintainer whether to squash-merge or true-merge at the end. Considering the number of times that...

> should we wait until the scm-api-plugin new version will be released (i don't know what is the time interval here, or release schedule) before marking this PR as ready...

> Ok so If I understand correctly, since we change the version from incremental to that which was produced by CI/CD is that correct and can this be merged or...