Marijn Suijten

Results 1102 comments of Marijn Suijten

@Hanfeng23333 would you be able to test https://github.com/ash-rs/ash/pull/1016? There is no need to fetch the submodule, which currently points to a local patch to fix upstream `vk.xml` issues.

> `TaggedStructure` was only referenced in utility macros `match_out_struct` and `match_in_struct` Not true, these are also referenced inside `default()` constructors, while also providing users direct access to information from `vk.xml`....

This, in hindsight, makes me wonder if it was ever designed/desired for the `*Extends` trait to be object-safe and dispatchable. Requiring `: Sized` on those traits would have also opted...

A few things I've been fighting from the guide so far, when *building inside Xcode*: - Unless I can make the build fail immediately because `cargo` is not found, I...

To add to that, Vulkan 1.4 doesn't require any of those alleged parser (neither _generator_, in case you meant that?) changes; the PR with the new API has been open...

1.4 itself does not, but we do have some breaking changes (to fix aforementioned soundness issues and hide `provisional` extensions) that will be part of the same _breaking_ `ash` release....

For context, you set `unsafe-default-safety.not-bounds-affecting = true` in #792. Which way do you expect to address all the false-positives? Should we set all those to `.unsafe = false`, or should...

> That depends on what the pattern for what's safe here actually is? That was mostly concerning false-positives like `setIndexType` receiving a `# Safety` comment about bounds-checking, despite taking an...

Can't conclusively say, but might be interesting to test the type-check and see the diff? Right now it's too large to manually read all false-positives (by means of searching for...

Yeah that's what I meant, but it's already 121 hits with most files collapsed because of the large diff. IIRC it's also where most of the [`4255-1865` additions](https://github.com/madsmtm/objc2-generated/compare/8bb1a3b5096cc34d8889d8ddf1016434a770fe9d...a6560b215be4350e1327ea9793c1ed9a1dee5610) come from?...