Marijn Suijten
Marijn Suijten
> I think we should have `wgt::InstanceDescriptor` have a `Box
> Edit: Clone is not dyn-safe. I think we should remove the impl of Clone. That is correct. Currently only one web workaround seems to require it to be clone,...
> Bleh we should just remove the & from InstanceDescriptor - we need to take ownership now. Don't you like it when a struct requires cloning/moving owned objects into it......
> This might fix #2384 too? Unsure, if I read that issue correctly it seems to revolve around creating `wgpu::Surface`s for multiple backends on the same underlying Android `Surface` or...
> Alright, if you have an idea of what the API would look like, then you can go ahead, I was mainly trying to get roadblocks and places for bikeshedding...
CI keeps failing on: ``` error: unused import: `num_traits::float::FloatCore` --> naga/src/back/pipeline_constants.rs:22:5 | 22 | use num_traits::float::FloatCore as _; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings` =...
Is there anything in the new edition that is needed to implement newer code? Is there a particular reason to not bump straight to `edition 2024`? And/or bump the MSRV...
Fwiw the reason I ask is because the PR description says "Carrying parts from #75" while that PR doesn't yet bump the edition at all (EDIT: right, it was reverted...
Let's not pin the version but rather communicate the minimum requirement via `rust-version = "1.85"` in `Cargo.toml`? Note that this is inferred based on `edition = "2024"` but it prevents...
How about the CI MSRV check?