Marijn Suijten
Marijn Suijten
Almost forgot to mention: can you please drop the `chore:` prefix from your commit messages? It's not used by this project and does not have any meaning in this context....
I'm thinking of raising the MSRV unconditionally, that seems a lot less tricky to users than pretending it's `1.71`, as long as they turn on the `"std"` feature 😅
I've squashed everything down into a single commit because our branch protection requires every individual commit to have been signed. Even if squash-merging will squash and resign the entire PR...
I recall checking **long ago** that `Backtrace::Captured { .. }` used to be quite small back in the day, is that no longer the case? Regardless, this saves us some...
Should the PR title be prefixed with `vulkan:` or are you intending to add this to the other backends (dx12 and Metal) as well?
@Jasper-Bekkers that should be https://github.com/Traverse-Research/gpu-allocator/pull/70, which explains it's a minor reduction in struct size.
> In `ci.yml`, we have (twice): > > ``` > - if: ${{ matrix.target == 'aarch64-pc-windows-msvc' }} > run: | > echo "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\Llvm\x64\bin" >> $GITHUB_PATH >...
> In the commit message: > > > build: Don't overwrite clang-cl with clang for ARM64 Windows builds > > here and elsewhere you use the word "overwrite" when I...
> So, when the compiler is clang-cl, we need to pass the clang-cl equivalent of `-std=c11` . The format for this seems to be `/std:c11`, but it does not resolve...
I've rewritten the patch and description: 1. We now use `clang-cl` in place of `clang`, because: 1. The error I got when cross-compiling (passing `cl.exe` arguments to `clang` instead of...