theforeman
Fixes #38295 - Make the chart clickable and show tooltip
This will probably need some adjustments (maybe for pf5?), when I try this on top of latest master I'm getting this when visiting the page
@adamruzicka in future, could you attach the whole error? as the screenshot just tells us that there is an error and all of its details are above the text you screenshotted :) (I'm also looking into this error) I suggest we pause this fix until we get the charts to pf5 so we can use our time better. (this might happen after removing foreman-js)
Right, sorry about that. When I try again there's also this (and nothing else). The errors are interleaved with various other things, I must have scrolled past this one previously, I don't really recall seeing it before
yeah so renderInPortal={false} dealt with that cause then it just didnt render he portal so it couldnt create errors, but I guess there was a reason why things should be in the portal? :shrug:
No idea, some internal things for charts it seems? PF docs say:
When renderInPortal is true, rendered tooltips will be wrapped in VictoryPortal and rendered within the Portal element within ChartContainer.
Just know that it causes errors
The chart should be working correctly now.
-
The tooltip is on purpose at the top of the chart, so it doesn't cause any issues and doesn't get cropped.
-
Title in
JobInvocationConstants.jschanged totitle: ' 'to fix this: -
Changes in
TemplateInvocation.jswere made to fix this:
Edge case: If I choose from the chart "failed" and then change the filter in the table to "Succeeded" and then choose from the the chart failed again it doesnt change selection.
@MariaAga Nice catch, thank you. It's fixed now.