Margaret Duff

icon company STFC - UKRI icon location Computational Scientist in Imaging - STFC - UKRI

Results 90 comments of Margaret Duff

SAG and SAGA approximate gradient methods

![image](https://github.com/TomographicImaging/CIL/assets/43645617/5219c076-5cc9-4cbf-80be-875706306111) Any thoughts on this wording?

SAG and SAGA approximate gradient methods

https://github.com/TomographicImaging/CIL/pull/1624#discussion_r1671008081 Thanks @jakobsj - In regards to this comment, I have added documentation explaining mathematically what approximation is taken at each iteration and thus SAG and SAGA is more easily...

SAG and SAGA approximate gradient methods

Thanks @paskino for getting this over the line!

Step-size methods and preconditoners for GD

Closes #1817

Step-size methods and preconditoners for GD

Jenkins is happy ![image](https://github.com/TomographicImaging/CIL/assets/43645617/06cd5101-a880-4dae-b9cc-1c8d7eb9be4b)

Improved documentation layout for algorithm class

![image](https://github.com/TomographicImaging/CIL/assets/43645617/82dc47a1-3872-4e4d-ba41-a1cd5ddda8d4) ![image](https://github.com/TomographicImaging/CIL/assets/43645617/b58c2b36-016c-44c7-9405-7c7ee00d00fe) ![image](https://github.com/TomographicImaging/CIL/assets/43645617/42b99462-23ab-40d6-ab1c-40245526f482) ![image](https://github.com/TomographicImaging/CIL/assets/43645617/a9db3a87-5eff-4b01-82e2-b7cbd3bd4d32) ![image](https://github.com/TomographicImaging/CIL/assets/43645617/651f865b-e23b-42a1-8bdf-cfcb66cdf727)

Improved documentation layout for algorithm class

Jenkins is happy ![image](https://github.com/user-attachments/assets/871e5e22-aa47-4b99-bd49-ad25a2233eff)

SVRG and LSVRG approximate gradient methods

> I was starting to look at this and see it contains some of the same code that is provided by #1550, on which changes are currently being implemented. What...

SVRG and LSVRG approximate gradient methods

Jenkins is happy ![image](https://github.com/user-attachments/assets/3b4ef7d2-f942-48e2-86a1-c934628be02e)

Add utility to configure PDHG for with explicit TGV or TV regularisation

Hi @lauramurgatroyd - I like the style of the unit tests for explicit TV. They are comprehensive without being expensive. I have suggested a few changes to them and made...