Margaret Duff

Results 90 comments of Margaret Duff

@AnderBiguri That works! ```python ##2d image example - 1 slices from tigre.utilities.im_3d_denoise import im3ddenoise from cil.utilities import dataexample import numpy as np from tigre.utilities.gpu import GpuIds, getGpuIds, getGpuNames from cil.utilities.display...

Thanks Ander - We have it in CIL and can't remember why we use it either :)

Seems to be passing this morning (although slowly) https://github.com/TomographicImaging/CIL/actions/runs/15047473746/job/42345710795?pr=2158

In GD we just chicken out if it isn't a constant step-size: https://github.com/TomographicImaging/CIL/blob/3230c7599ab40839098d1deebbd5c444f67f7d69/Wrappers/Python/cil/optimisation/algorithms/GD.py#L138-L144 We should probably be consistent

Discussed in the dev meeting this morning. To get around the question of it should scale like an Operator or like a BlockOperator could be avoided if we added a...

@fmwatson Thanks again for this PR - I would appreciate it if you had a few mins to look at it again to check you are happy with all of...

Hi @fmwatson - just checking in on this PR? Did you have chance to check it with your code? If you are happy, I will review it again and then...

Thanks Maike! Will take a look

I had a play with this to try and optimise memory usage. Compared to CGLS, I still need to get rid of one stored image copy. Will discuss with Gemma...