Manish Goregaokar

Results 596 comments of Manish Goregaokar

Yeah, I managed to make it work with this instead: ``` // &[u8] and &[T::ULE] are the same slice with different length metadata. let data = bytes.as_ptr(); let mut metadata...

I understand, but I will point out that currently what is and isn't UB is in flux (and almost completely undocumented), and also a lot of the APIs to do...

> I do agree with the concern that our UB rules can be hard to follow. However, note that the UB involved here is much more clearly documented than most...

> It is very easy for interpreter changes to "accidentally" improve or regress UB detection, and we need the ability to continue evolving that interpreter without going through a month-or-year-long...

@saethlin Probably, yeah, I'd even be happy to run a build under some rustflag to opt in if I knew about it (but stuff here changes so often it's hard...

> I guess the only answer I have here is that i'll be more careful in future reviews. Not sure what else to do with the current capacity we have...

> I wonder if Rust should define UB on each edition (2018, 2021, ...), and change the definition in tandem with the edition, in order to give maintainers an opportunity...

> Thanks for sharing this; I was not aware that this is a common sentiment. > > I think it reflects well how we have been treating runtime UB, but...