David Gonçalves

Results 14 comments of David Gonçalves

I just checked and I think it is a false positive, sorry.

@kirbyfan64 I am inclined to believe that it is related with libstdc++ not being compiled with memory sanitizer, not sure though.

There is no reason to use `#ifdef UNICODE`, because when UNICODE isn't defined, `WriteConsoleOutputCharacter` simply calls `WriteConsoleOutputCharacterA`.

Same should be done for line 580, C version.

Shocked to see this issue is from 2016 and nothing has been done about it. :(

Thank you for your help! I'll leave the issue open in case you ever have the time and interest to write a plugin for GitLab.

Adding to this request. When compiling with C++11 I get a bunch of warnings of zero as null pointer. Please add something like: ```cpp #if !defined(__cplusplus) || __cplusplus < 201100L...

@RauliL Thank you! This is not as good as readline (e.g. files that are not in current directory), but it is something.

@RauliL I could do that. But don't you think that a library that claims to be a replacement for readline should do it?