`setConsoleTitle` strings

[MangaD]

trafficstars

There is a problem with the setConsoleTitle function. It uses const char * as string parameter for the print function when compiling with C++. This seems to be a problem because when compiling with clang++ and with the flag -fsanitizer=memory, I just get a warning about uninitialized value at the line: RLUTIL_PRINT(true_title);

So, I'd advise to change the code of that function to:

RLUTIL_INLINE void setConsoleTitle(RLUTIL_STRING_T title) {
#if defined(_WIN32) && !defined(RLUTIL_USE_ANSI)
#ifdef __cplusplus
    SetConsoleTitleA(title.c_str());
#else
    SetConsoleTitleA(title);
#endif
#else
    RLUTIL_PRINT(ANSI_CONSOLE_TITLE_PRE);
    RLUTIL_PRINT(title);
    RLUTIL_PRINT(ANSI_CONSOLE_TITLE_POST);
#endif // defined(_WIN32) && !defined(RLUTIL_USE_ANSI)
}

[nabijaczleweli]

Looks :+1: if it's not a false positive. Submit a PR.

[MangaD]

I just checked and I think it is a false positive, sorry.

[nabijaczleweli]

It did seem to be :P

[refi64]

@MangaD It could be that whatever you're passing as title has uninitialized bytes or something.

[MangaD]

@kirbyfan64 I am inclined to believe that it is related with libstdc++ not being compiled with memory sanitizer, not sure though.