Luca Cominardi comments

Results 160 comments of


                                            Luca Cominardi

remove `new_timestamp(id)` standalone function, keep it only as a method of the `Session`

Completed

[dev/1.0.0] Rename `publisher`/`subscriber` modules into `publication`/`subscription` and merge `queryable` into `query`

Another option could be to unify `pub` and `sub` in `pubsub`. Similarly for `query` and `queryable` unified into `query`.

[dev/1.0.0] Rename `publisher`/`subscriber` modules into `publication`/`subscription` and merge `queryable` into `query`

@wyfo Could you open a PR that address this issue plus https://github.com/eclipse-zenoh/zenoh/issues/1147 and https://github.com/eclipse-zenoh/zenoh/pull/1160? I think we should converge on this aspect pretty soon before the final `1.0.0` release.

[dev/1.0.0] Rename `publisher`/`subscriber` modules into `publication`/`subscription` and merge `queryable` into `query`

Closed by https://github.com/eclipse-zenoh/zenoh/pull/1193

panic in `transport_tcp_concurrent` on windows on github CI

It seems the CI has been happy for a while now and the test didn't fail anymore. Closing the issue. Feel free to reopen it if it's still relevant.

Remove some duplicate imports

I'm not sure about this change... @milyin ?

Remove some duplicate imports

Superseded by https://github.com/eclipse-zenoh/zenoh/pull/1193

feat: rename `zenoh::try_init_log_from_env` to `zenoh::init_logging`

I disagree on this PR. `try_init_lof_from_env` is more explicit on the fact the logging could not be initialized. Moreover, this kind of change requires updating all the plugins, backends, and...

feat: rename `zenoh::try_init_log_from_env` to `zenoh::init_logging`

A logging rework should be done throughout the whole Zenoh ecosystem. I'll try to enumerate what I believe current issues are: 1. Logging level is too coarse. Moving from debug...

feat: rename `zenoh::try_init_log_from_env` to `zenoh::init_logging`

Closing this PR because it's outdated and longer relevant after `1.0.0` release.