Jake Potrebic

Results 499 comments of Jake Potrebic

Rebased and now fixes https://hub.spigotmc.org/jira/browse/SPIGOT-7438 as well.

I believe this is addressed by https://github.com/PaperMC/Paper/pull/8727

I think a lot of this diff can be reduced by not renaming the local vars right? It really clutters up the diff making it hard to see what actually...

I'm just guessing here, but I bet I know what causes this. If a player is in range of the jukebox when it starts playing (within 64 blocks), it gets...

I'm gonna wait a week on this issue if the reporter or anyone else chimes in with something, but this really isn't fixable without trying to track on the server...

Just found this actually, which while not exactly this issue, does speak, I think, to mojang's lack of interest in addressing the desync of jukeboxes and players. https://bugs.mojang.com/browse/MC-10436

I added a note about this method potentially causing chunk loads/generation if the position isn't loaded and added a helper method to check if a Position is loaded or not.

Just realized this also affects the merging on spawn logic as well. It does not account for the count of orbs being different. For example, if you have an orb...

> Not 100% sure but I remember something about the count only being meant for the visual display of the orb as stacked and the value simply being the sum...