Jake Potrebic
Jake Potrebic
The API doesn't really have the concept of chunk sections... is it worth adding that just for this? Is there anywhere else in the API that could use chunk sections...
I'm not opposed to it, mainly on the consistency basis. I think such a method should probably come with a helper method on Chunk & ChunkSnapshot to convert a y...
> so perhaps isSectionEmpty(Chunk.segmentIndex(yCoord)), as you describe having a helper method for this? It can't be a static method because it has to have the world height, specifically the min...
> How about using @Deprecated and @APIStatus.ScheduledForRemoval() for feature flags enabling updates? Deprecated seems inappropriate for this, and scheduledforremoval might work for UPDATE_1_20, but not bundle as we have no...
The enum PR was the PR previous thought to be slated by upstream for 1.20. It replaces a ton of the enums and deprecates Material.
Ok, revamped this and took over as much as possible from upstream's feature flag API. Added tests to ensure nothing is missed as well.
Refactored to just check if server.properties exists at all before trying to read from it. If it doesn't, just return empty properties and log a regular line saying default values...
The issue this was created to address doesn't exist anymore as upstream removed their arbitrary limit on sign text length (2048). Can revisit if we want to make the banner...
Rebased for 1.19.2
Updated to fix an additional issue. Previously, the extended lifetime of nether stars from withers was ignored, this also fixes that.