Jake Potrebic

Results 141 comments of Jake Potrebic

I agree with @Owen1212055. We can just remove the check. No such check exists for the fire call.

Dramatically refactored this to an, imo, much better and more extensible system for predicate choice coming later. Details of how this works in PR description.

Done in https://github.com/PaperMC/Paper/commit/18fabc08d52ecbddd993d17fb06c51db27941014

Rebased for 1.19.4

> can we use your code generation stuff to generate the keys? Yes, absolutely. If we want to start using the code generation stuff, then we need to move away...

Rebased and updated for 1.20.4. I refactored the API types into interfaces backed by server impls. Much more future proof doing that.

I think these should def be displayed. It is invalid and just leaving or ignoring invalid input isn't a good thing here.

No, `syncCommands` has nothing to do with threading. the `sync` just means "match up". `syncCommands` is a method that makes the bukkit command map and the brig dispatcher have the...

This is directly configurable with datapacks, just by setting `monster_spawn_light_level` in the overworld dimension type. Unsure if we want to add a setting to address this. Either way, I do...

Confirmed. Currently, the custom flattener that is used to flatten translatable components into strings (for the ansi, plain text, and legacy serializers) only uses instances of `Translator` that are `TranslationRegistry`...