Paper
Paper copied to clipboard
PaperMC
Better Stats API
Still needs some javadocs
And if this is good, replacing uses of the bukkit statistic enum.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
Rebased for 1.18.2. Also changed the PlayerIncrementStatisticEvent to use the new api, forgot about that one.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Ok, think I finally finished integrating with upstream's new Criteria API. Unsure if we should deprecate Bukkit#getScoreboardCriteria. I really do not know why this object needed an Craft implementation, rather than just a conversion method. Maybe that's what my criteria API pr could do, just get rid of CraftCriteria entirely.
can we use your code generation stuff to generate the keys?
Yes, absolutely. If we want to start using the code generation stuff, then we need to move away from putting all the constants in the same file as the actual type. So like in this case, CustomStatistics would be the holder class for all of them, while CustomStatistic would be in source. That way, the generation is just the keys, and doesn't have to include any methods.
Rebased and updated for 1.20.4.
I refactored the API types into interfaces backed by server impls. Much more future proof doing that.