Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Use DataConverter for itemstack/entity deserialization

Open Machine-Maker opened this issue 3 years ago • 6 comments

In 1.17, the deserializeEntity method in UnsafeValues used the dataconverter system over the builtin datafixer. Until the failing cb tests can be addressed using the new (since 1.18-pre5 for DataConverter) hooks, probably should restore that same behavior here.

Machine-Maker avatar Dec 09 '21 22:12 Machine-Maker

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 21 '22 03:02 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 24 '22 03:04 stale[bot]

This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue.

stale[bot] avatar May 01 '22 16:05 stale[bot]

rebased for 1.18.2

Machine-Maker avatar Jun 01 '22 02:06 Machine-Maker

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 31 '22 08:07 stale[bot]

Rebased for 1.19.1

Machine-Maker avatar Aug 01 '22 02:08 Machine-Maker

Done in https://github.com/PaperMC/Paper/commit/18fabc08d52ecbddd993d17fb06c51db27941014

Machine-Maker avatar Jan 24 '23 15:01 Machine-Maker