Imran Asghar

Results 12 comments of Imran Asghar

Hi @ggeisler Thanks for the feedback. I agree with your point about the annotation card overlay being somewhat distracting when hovering over the annotations. In that case, I will continue...

Hi! so I made the changes to Mirador here. Displaying dialog to show full image instead of card https://github.com/ProjectMirador/mirador/pull/3435

Hi @stephenwf , just to make sure i understand correctly, in this case sequence interface would list out the definitions for all functions and types needed for sequence and be...

Hi guys, the reason I made the changes in https://github.com/IIIF-Commons/manifesto/pull/79 of returning only top level canvases of the range, was because ranges with `sequence behaviour` are not nested. so basically,...

I think using both would be okay too in case of v3 and just getSequences in case of v2.

Hi guys, I was wondering what you guys are thinking as final decision on this to proceed? I would love to work on any further changes that need to be...

I gave something similar a try here https://github.com/IIIF-Commons/manifesto/pull/84 which we can use in combo with #79 . Here `getSequences` return either sequence or range or both. Thinking that the reason...

Hi @stephenwf , did you get a chance to look at the above two pull requests?

Ah interesting, looking into it 👍

Hi @stephenwf , fixed the tests