manifesto icon indicating copy to clipboard operation
manifesto copied to clipboard

Add 'get' canvas functions to ranges

Open MImranAsghar opened this issue 5 years ago • 5 comments

  • Add getCanvases, getCanvasById, getCanvasByIndex functions for the range type

MImranAsghar avatar Nov 23 '20 09:11 MImranAsghar

I'm not sure why, but 3 tests appear to be failing now:

195 passing (2s)
  3 failing
  1) pres3 presentation 3 range has a canvas:
     TypeError: Cannot read property '__jsonld' of undefined
      at context.<anonymous> (test/tests/pres3.js:48:96)
  2) pres3 presentation 3 has an annotation body:
     TypeError: Cannot read property 'getContent' of undefined
      at context.<anonymous> (test/tests/pres3.js:54:26)
  3) pres3 presentation 3 has a label:
     TypeError: Cannot read property 'getLabel' of undefined
      at context.<anonymous> (test/tests/pres3.js:62:26)

stephenwf avatar Jan 22 '21 13:01 stephenwf

Ah interesting, looking into it 👍

MImranAsghar avatar Jan 22 '21 15:01 MImranAsghar

Hi @stephenwf , fixed the tests

MImranAsghar avatar Jan 22 '21 17:01 MImranAsghar

Hi @stephenwf , I was wondering if you got a chance to take a look at the changes. do you think this can be merged? 🤔

MImranAsghar avatar Mar 02 '21 20:03 MImranAsghar

Sorry yes I think so 👍 @edsilv ?

stephenwf avatar Mar 03 '21 10:03 stephenwf