Kimera-VIO icon indicating copy to clipboard operation
Kimera-VIO copied to clipboard

Allow for n distortion params

Open ToniRV opened this issue 5 years ago • 5 comments

ToniRV avatar Jun 29 '20 22:06 ToniRV

@ToniRV Is this ready to pull? My review will be to build and use it lol

violetteavi avatar Jun 30 '20 18:06 violetteavi

Ready yes! Let me know how it goes!

ToniRV avatar Jun 30 '20 18:06 ToniRV

@ToniRV When I build it with current Kimera-VIO-ROS master , I get the following error:

/home/andrew/catkin_ws/src/Kimera-VIO-ROS/src/utils/UtilsRos.cpp:84:58: error: ‘class VIO::CameraParams’ has no member named ‘calibration_’; did you mean ‘camera_id_’?
                                             &cam_params->calibration_);

Do you have a pair of Kimera-VIO and Kimera-VIO-ROS branches that compile here?

violetteavi avatar Jun 30 '20 21:06 violetteavi

It looks like Kimera-VIO-ROS has a stubbed method for mapping coefficients to gtsam calibration functions. Because the calibration_ field appears to have been removed in the refactor, I assume this stubbed method is no longer necessary-- I'm going to remove it and see if it compiles.

  VIO::CameraParams::createGtsamCalibration(cam_params->distortion_coeff_,
                                            cam_params->intrinsics_,
                                            &cam_params->calibration_);

violetteavi avatar Jun 30 '20 21:06 violetteavi

Fixed Kimera-VIO-ROS branch fix/distortion. It compiles-- going to test the five-parameter distortion models now.

violetteavi avatar Jun 30 '20 21:06 violetteavi