Maciej Bartkowiak

One side problem is that the changes here will make the unit tests fail: `MDANSE_GUI/Tests/UnitTests/test_JobState.py` It is not a problem for now, but it will come back when #704 is...

Everything looks fine. Only the GUI unit tests still seem to have a problem when I run them. ``` test_FileObject.py . [ 6%] test_GeneralModel.py ... [ 25%] test_JobState.py FF [...

Would you agree that the main reason for the RegisterFactory class is to register the subclasses explicitly and not automatically?

Overall, the suggested changes are looking good. Especially with generators being generators, and the clear examples in the docstrings. It looks promising in the context of issues #446 and #458...

Would it make sense to use the label "commensurate" instead of "lattice" vectors? I guess that the best term for it will depend on the science field of the user.

Should we just add some command in the Ubuntu workflow to install the missing library? Like `apt install libegl1`, or something more specific like `apt install libegl1-mesa-dev`?

I expect this to be fixed by #841

Agreed, definitely a good idea.

To replace **all** of them would be a significant amount of work, but also a big improvement for long-term maintainability of the code. But you are right that many of...

I am looking at the atom properties now, in connection to #713 and #718 For neutron properties, I would normally refer to the NIST tables: https://www.ncnr.nist.gov/resources/n-lengths/list.html According to them, 3He,...