MDANSE icon indicating copy to clipboard operation
MDANSE copied to clipboard

[RFC] Qvectors rework

Open oerc0122 opened this issue 11 months ago • 3 comments

Description of work Implement independent new scheme for handling Q-Vectors without shells.

Fixes Fixes #656 Fixes #458 Fixes #446 Fixes #705

To test New tests in UnitTests/NewQVectors

oerc0122 avatar Mar 17 '25 16:03 oerc0122

Would you agree that the main reason for the RegisterFactory class is to register the subclasses explicitly and not automatically?

MBartkowiakSTFC avatar Mar 20 '25 08:03 MBartkowiakSTFC

Would you agree that the main reason for the RegisterFactory class is to register the subclasses explicitly and not automatically?

Yeah, it also means you can have multiple aliases (if desired) and you can have more than one class per file allowing sensible grouping.

Scanning files is not terribly safe and also means that it's picking up temporary files from my editor.

oerc0122 avatar Mar 20 '25 08:03 oerc0122

Overall, the suggested changes are looking good. Especially with generators being generators, and the clear examples in the docstrings.

It looks promising in the context of issues #446 and #458 so definitely we should go ahead with these changes.

MBartkowiakSTFC avatar Mar 20 '25 09:03 MBartkowiakSTFC