Guillaume Fraux

Results 464 comments of Guillaume Fraux

So this notebook runs fine for me with the latest master. Did you make any changes to it by chance? In particular to the `spherical_expansion_hypers`? If not, what Os are...

Since this is exploiting undefined behavior, the exact set of optimization flags, and exact GCC version matter. @felixmusil, did you run this in debug or relase mode? And adding -`fsanitize=undefined`...

Before doing a release, I would like to fix at least #383, otherwise users with a M1 apple computer will not be able to compile & install librascal. But we...

Sorry, missed the comment. There is a PR with some initial support here https://github.com/chemfiles/chemfiles/pull/192 but @frodofine since took a full time industry job and no longer has time to work...

I think that the best way to do this will depend a lot on what users are already using for their docs. For pure sphinx, we could provide a small...

The sphinx-gallery seems to be the easiest one to fix: we mainly need to add a `__repr_html__` function to `ChemiscopeWidget` and friends, https://github.com/lab-cosmo/chemiscope/blob/9b5c9b12b1b005a599488bf867a69d02f8c823e0/python/chemiscope/jupyter.py#L60 containing the same kind of HTML as...

What's the status on this? Should we close & reopen later when someone has time to implement it?

Sure, I'm just trying to clear PR no-one is working on. Should I close this PR and keep the branch around?

I fully disagree. There is more here than portability, i.e. possible memory corruption bugs as demonstrated above. Also this creates a very bad user experience, where the code breaks for...

Since this is intended for a specific deployment of chemiscope at NOMAD, another possible solution would be to replace the map widget entirely, and only re-use the other parts of...