chemiscope icon indicating copy to clipboard operation
chemiscope copied to clipboard

Published 20 hours ago • verified publisher icon lab-cosmo

Python-side selection

Open ceriottm opened this issue 1 year ago • 4 comments

Traitlet-based synchronization of the selected structure. Facilitates interaction with other ipywidgets. We should also use this to Fix #244 for good.

ceriottm avatar Nov 13 '23 01:11 ceriottm

What's the status on this? Should we close & reopen later when someone has time to implement it?

Luthaf avatar Jan 04 '24 15:01 Luthaf

well, it's actually kind of working. there are some problems handling multiple viewers and the synchronization with the map. I think it however might be good to keep this on hold until we have done something about #326, as I think one underlying issue is that the settings synchronization mechanism is not well documented and so there's a lot of guesswork.

ceriottm avatar Jan 06 '24 08:01 ceriottm

Sure, I'm just trying to clear PR no-one is working on. Should I close this PR and keep the branch around?

Luthaf avatar Jan 08 '24 14:01 Luthaf

I'd leave it on if you don't mind. I think it might take half an hour if we look at it together.

ceriottm avatar Jan 08 '24 18:01 ceriottm

We'll re-open this whenever we have time for it!

Luthaf avatar May 24 '24 13:05 Luthaf