Guillaume Fraux

Results 461 comments of Guillaume Fraux

That's unfortunate, but make sense given how everything is implemented. I could see a couple of options here: document the issue and tell people to use code based on `serde::with`...

So I agree that having an option to specify the generated structs names would be nice. I don't have a lot of time, but I would welcome a PR implementing...

Let's try to find a solution for #44 before merging though.

Mainly to silent compiler warning while doing ``` cpp int num = args["--num"].asLong(); ``` But I do agree this is not a big feature.

Thanks a lot for creating the PR! I think the first thing we should discuss is how we want to store multi-dimensional properties in the datasets. The current approach (using...

Could you rebase this branch on top of master, now that most of the sweeping changes are done?

So `activeChanged` is used when there are multiple structure viewers, to change the active one (bigger marker on the map). Theoretically, calling `DefaultVisualizer.map.onselect()` and then `DefaultVisualizer.map.select()` with the same arguments...

`select()` should work now! I'll leave this open to add a nicer API to do this kind of things.

Trying to run this code gives me this error whenever I load a dataset ``` AssertionErrorERR_ASSERTIONisFinite(min) && isFinite(max) Backtrace Wrapper@http://localhost:8080/chemiscope.min.js:1728:473 AssertionError@http://localhost:8080/chemiscope.min.js:2073:80 innerOk@http://localhost:8080/chemiscope.min.js:1208:15 ok@http://localhost:8080/chemiscope.min.js:1227:11 arrayMaxMin@http://localhost:8080/chemiscope.min.js:149249:14 ./src/map/map.ts/PropertiesMap

Can you rebase & fix CI? After that I remember the main part of work remaining with this feature was the user interface side of it. Do you have some...