Luni-4 comments

Results 153 comments of


                                            Luni-4

Move more repeated functions and traits into `burn-common` crate

@nathanielsimard Thank you for pointing me to the right directory! Yeah, we can use `burn-common` an apply the strategy described above. I agree!

Move more repeated functions and traits into `burn-common` crate

Yep, I agree, thanks @antimora!

Load `yolov8` network into `burn-rs`

Thank you @antimora! Yep, you're right, `Reshape` is already implemented

Document how to update grammars

Sure! I'm going to add `tree-sitter-java` update soon

QUESTION: Change metadata/tags

Sorry for the late reply @VladAdGad, we are trying to refactor this crate, so many things are still unstable and not implemented, but your feature would be interesting to have

Parses simple blocks after a block group are silently ignored.

@Matthias-Fauconneau What's the status of this PR?

Parses simple blocks after a block group are silently ignored.

Could you please open an issue specifying what is left to do and close this PR? In this way I can remember what we need to implement :) Thank you!

Should String Elements and UTF-8 Elements be handled differently?

Just my opinion, but I prefer being compliant with the specification in order to have a clear and unanmbiguous implementation. Is a big effort converting bytes into UTF-8 or ASCII...

Should String Elements and UTF-8 Elements be handled differently?

> You do not have to convert anything, you have to reject non-ascii if your target is an ascii string. Is this spec compliant? If we find an ascii string...

Should String Elements and UTF-8 Elements be handled differently?

@FreezyLemon I agree with your analysis