matroska icon indicating copy to clipboard operation
matroska copied to clipboard

Parses simple blocks after a block group are silently ignored.

Open Matthias-Fauconneau opened this issue 3 years ago • 3 comments

Simple blocks after a block group are silently ignored. Parsing into the existing simple_block would reorder. This parses all simple blocks into struct BlockGroup to allow any interleaving of simple blocks or block groups inside a cluster while preserving the order. If that's an acceptable solution, the serialization needs to be updated.

Matthias-Fauconneau avatar Oct 30 '22 11:10 Matthias-Fauconneau

@Matthias-Fauconneau What's the status of this PR?

Luni-4 avatar Mar 30 '23 07:03 Luni-4

I think that's the proper solution. Deserialization works for me. You might want to also do the serialisation part though.

Matthias-Fauconneau avatar Mar 30 '23 12:03 Matthias-Fauconneau

Could you please open an issue specifying what is left to do and close this PR? In this way I can remember what we need to implement :)

Thank you!

Luni-4 avatar Mar 30 '23 12:03 Luni-4