rust-code-analysis icon indicating copy to clipboard operation
rust-code-analysis copied to clipboard

Document how to update grammars

Open Luni-4 opened this issue 2 years ago • 3 comments

This PR fixes #979

It adds to the developer section of the book a guide to update both third-party grammars and internal grammars.

Luni-4 avatar Dec 19 '23 18:12 Luni-4

Looks good to me, but could you try to do a grammar update following the steps here to make sure nothing was missed?

marco-c avatar Dec 20 '23 13:12 marco-c

Sure! I'm going to add tree-sitter-java update soon

Luni-4 avatar Dec 21 '23 08:12 Luni-4

@Luni-4 ping :)

marco-c avatar Apr 03 '24 10:04 marco-c

@alexle0nte did you follow the steps documented here for https://github.com/mozilla/rust-code-analysis/pull/1086? Is there anything missing that we should add?

marco-c avatar Aug 05 '24 16:08 marco-c

did you follow the steps documented here for #1086? Is there anything missing that we should add?

Yes, I followed these steps. Regarding the update of grammar versions, the guide is complete. If I notice anything missing while fixing the tests, I'll report it

alexle0nte avatar Aug 06 '24 13:08 alexle0nte

Perfect, thanks!

marco-c avatar Aug 06 '24 13:08 marco-c