Cory Benfield

Results 1307 comments of Cory Benfield

It would need to be done in urllib3.

@benoitc For HTTP/2, if you're interested in supporting it using [hyper-h2](http://python-hyper.org/h2/) I may be able to spare some time to do help out with integration work.

@benoitc You bet! Come join us in #python-hyper on freenode whenever suits.

I don't think @gwynne's diagnosis here is right. Signal sources on Linux are essentially a [wrapper around `signalfd`](https://github.com/apple/swift-corelibs-libdispatch/blob/f13ea5dcc055e5d2d7c02e90d8c9907ca9dc72e1/src/event/event_epoll.c#L169). This means that Dispatch does not do what @gwynne suggests (catch the...

Yes, all of the analysis applies to macOS as well. macOS doesn't have signalfd so you don't have to deal with the fact that it's bad, and managing signals on...

As to tracing down the issue, the first place I'd look is that I'd look very hard at _how_ Vapor waits for the event loops to be closed.

The code here is really quite unclear. `Application.start` seems to wait on the future from `running`. The flow control here is really uncertain but assuming that we successfully block there,...

> @Lukasa could you please elaborate a bit on how a Vapor application should shut down if the main thread is parked into the RunLoop? I tried looking around for...

The standard glibc `malloc` does not necessarily return memory to the OS when it is `free`d, yes. This is particularly true in cases where the heap is fragmented, in which...